Skip to content

Update 6.0 branch to use Ubuntu 22.04 queues for Perf runs #90762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carlossanlop merged 2 commits into from
Aug 31, 2023
Merged

Update 6.0 branch to use Ubuntu 22.04 queues for Perf runs #90762

carlossanlop merged 2 commits into from
Aug 31, 2023

Conversation

@DrewScoggins
Copy link
Member

@DrewScoggins DrewScoggins commented Aug 17, 2023

This updates the servicing branches to use the new Ubuntu 22.04 queues.

Customer Impact

None, as this does not change product code.

Regression?

No.

Testing

Currently running on main branches successfully

Risk

Low. This is not a product change, and as such I expect the risk to be zero.

cincuranet and others added 2 commits August 17, 2023 11:05
@cincuranet @DrewScoggins
Put crossgen perf into "Ubuntu.1804.Amd64.Tiger.Perf". (dotnet#90091)
277889a 
* Because crossgen need LTTng and 22.04 is not compatible.
* Windows using same queue.
@DrewScoggins
Roll Ubuntu 18.04 queue to 22.04 (dotnet#89995)
6e46c4e
@ghost ghost assigned DrewScoggins Aug 17, 2023
@ghost
Copy link

ghost commented Aug 17, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This updates the servicing branches to use the new Ubuntu 22.04 queues.

Customer Impact

None, as this does not change product code.

Regression?

No.

Testing

Currently running on main branches successfully

Risk

Low. This is not a product change, and as such I expect the risk to be zero.

Author: DrewScoggins
Assignees: DrewScoggins
Labels:

area-Infrastructure-coreclr
Milestone: -

jeffschwMSFT
jeffschwMSFT approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. I consider this tell mode. adding @carlossanlop on when it would be appropriate to merge.

@DrewScoggins
Copy link
Member Author

DrewScoggins commented Aug 17, 2023

Great. Also expect two more PRs like this for both of the 7.0 release branches as well :)

@carlossanlop
Copy link
Contributor

carlossanlop commented Aug 17, 2023 •
edited
Loading

Same question like in the release/7.0 branch: Can we close this and instead merge the release/6.0-staging equivalent PR, then wait until the release/6.0 branch opens again next month so we flow it there?

Edit: Today's branding day so I'm going to merge these perf PRs after we merge the branding PRs.

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Aug 31, 2023
@carlossanlop carlossanlop added this to the 6.0.x milestone Aug 31, 2023
@carlossanlop carlossanlop merged commit ea58909 into dotnet:release/6.0 Aug 31, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cincuranet cincuranet cincuranet approved these changes

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

@mangod9 mangod9 Awaiting requested review from mangod9

Assignees

@DrewScoggins DrewScoggins

Labels

area-Infrastructure-coreclr Servicing-approved Approved for servicing release

Projects

None yet

Milestone

6.0.x

Development

Successfully merging this pull request may close these issues.

4 participants

@DrewScoggins @carlossanlop @cincuranet @jeffschwMSFT